Changed the pm-names to legacy names is it good?

LINBIT SDS Integrations Proxmox VE
1

Hello everybody,

the pm-uuid names make me confused. That is why i have changed the the following block in:
vim /usr/share/perl5/PVE/Storage/Custom/LINSTORPlugin.pm

From

} else {
    for ( my $i = 1 ; $i < 100 ; $i++ ) {
        my $tn = "pm-" . lc substr( UUID::uuid(), 0, 8 );
        if ( !exists( $resources->{$tn} ) ) {
            $linstor_name = $tn;
            $proxmox_name = "${tn}_${vmid}";
            last;
        }
    }
}

To

} else {
    for (my $i = 1; $i < 100; $i++) {
        my $diskname = "vm-${vmid}-disk-$i";
        if (!exists($resources->{$diskname})) {
            $linstor_name = $diskname;
            $proxmox_name = $diskname;
            last;
        }
    }
}

Is it good or bad way? Is there any consequences? Is there better way?

for the new updates am planning to keep the custom-changes somehow

Best Regards
youzersef

2

I mean I did not change the naming because I woke up and had a funny day, obviously there is a reason that the naming is how it is :slight_smile: and the reason is moving disks between VMs. all there is to say about that is written down here: allow reassigning disks · LINBIT/linstor-proxmox@7027916 · GitHub

consequence? the feature will not work and you have to maintain your patch, besides that nothing I could think of right now. it is open source: good luck

3

Hello rck,

thank you. I missed to read this allow reassigning disks · LINBIT/linstor-proxmox@7027916 · GitHub

i did not try to change it, because i do not like this version of the disk name. My problem is that i want to shipp the snapshots to s3 storage. Just in case, if i want to restore a snapshot then i should to figure out which VM-Disk belongs to which VM.. and this will take to much time…

maybe i am thinking wrong. I am glade to hear advises :slight_smile:

Best Regards
youzersef